add applicability to span_suggestion call #54412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
jcpst
changed the title
This comment has been minimized.
This comment has been minimized.
estebank
approved these changes
Sep 21, 2018
| @@ -22,6 +22,7 @@ use std::collections::VecDeque; | |||
| use std::fmt; | |||
| use syntax::symbol::keywords; | |||
| use syntax_pos::Span; | |||
| use errors::Applicability; | |||
There was a problem hiding this comment.
I believe this needs to be use syntax::errors::Applicability.
| span, | ||
| &format!( | ||
| "to allow this impl Trait to capture borrowed data with lifetime \ | ||
| `{}`, add `{}` as a constraint", | ||
| fr_name, suggestable_fr_name, | ||
| ), | ||
| format!("{} + {}", snippet, suggestable_fr_name), | ||
| Applicability::MachineApplicable, |
There was a problem hiding this comment.
I feel it might be safer to use MaybeIncorrect here, but this might be fine in the wild. Lets keep it this way and fix it if we find positive proof that it is a problem.
jcpst
force-pushed
the
replace_span_suggestion
branch
from
d2cab27 to
7f9a259
Compare
|
@bors r+ rollup |
|
📌 Commit 7f9a259 has been approved by |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found another
span_suggestioncall. Issue #50723r? @estebank